Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] closing user being transmitted in close by visitor #9698

Closed
wants to merge 1 commit into from
Closed

[Fix] closing user being transmitted in close by visitor #9698

wants to merge 1 commit into from

Conversation

mrsimpson
Copy link
Collaborator

@mrsimpson mrsimpson commented Feb 13, 2018 •
edited by sampaiodiego
Loading

@RocketChat/core

Closes #9558

This fixes a "syntax error" violating the closeRoom method signature.

@sampaiodiego: is it semantically correct to pass Meteor.user() as closing use or should this also be the visitor

@mrsimpson mrsimpson mentioned this pull request Feb 13, 2018
Closed
@sampaiodiego sampaiodiego added this to the 0.61.1 milestone Feb 14, 2018
@sampaiodiego
Copy link
Member

is it semantically correct to pass Meteor.user() as closing use or should this also be the visitor

nope. unfortunately there is no Meteor.user() when visitor calls it.. this should not fix the issue

@renatobecker-zz
Copy link

renatobecker-zz commented Feb 14, 2018 •
edited
Loading

We are closing this PR because we are going to fix this issue unifying some methods that are still using the user property internally.
As a visitor is not a logged user, the Meteor.user() can't be passed to internal method.
After this fix, the user property will no longer be used.

Anyway, thanks for your effort and help.

@ruKurz
Copy link
Contributor

ruKurz commented Feb 14, 2018

As far I can see this PR is closed by #9714

@mrsimpson mrsimpson deleted the core/#9673-close-livechat-by-visitor branch December 7, 2020 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@renatobecker-zz renatobecker-zz Awaiting requested review from renatobecker-zz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.61.1
Development

Successfully merging this pull request may close these issues.

End livechat session
4 participants
@mrsimpson @sampaiodiego @renatobecker-zz @ruKurz